debugger console recognizes italic ansi code#67511
Merged
isidorn merged 13 commits intomicrosoft:masterfrom Mar 4, 2019
flurmbo:debug-console-ansi-italics
Merged
debugger console recognizes italic ansi code#67511isidorn merged 13 commits intomicrosoft:masterfrom flurmbo:debug-console-ansi-italics
isidorn merged 13 commits intomicrosoft:masterfrom
flurmbo:debug-console-ansi-italics
Conversation
Collaborator
|
Thanks for your PR. Not for endgame, will review once I am back from vacation in 2 weeks |
Collaborator
|
This looks good.
|
Contributor
Author
|
@isidorn sure I'll try to get to it in the next few days! |
Contributor
Author
|
Hey @isidorn I made the changes you asked for, let me know what you think! |
Collaborator
|
Thanks a lot. This week we are in endgame which means we only bugfix and take limited changes. Due to that I am assigning this to march and I will probably review next week. |
Collaborator
|
@flurmbo great work, merging this in. Nice tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #67510