Add git.pullTags setting

[hhu94]

Fixes #67424

[alejandroiglesias]

I was hoping for this to be released in the January release 😞

[hhu94]

Sadly even if this PR had been merged immediately after creation it would probably still have been put on the Feb release. Hopefully @joaomoreno finds some time to review this, although he's most likely busy with more important work.

[adamtajti]

I think the PR looks fine. I was thinking about this a bit though and I have a small suggestion to make.

Since the default value for the "git.pullTags" settings is true, the behavior will remain the same for those who uses the problematic tag workflow and don't know about the existance of this flag.

I think it would result in a better user experience if we could raise awareness to this flag when the "would clobber existing tag" substring is detected in the err.stdout output of the catch(err) { ... } clause and/or mention the --force switch as a possible workaround.

[alejandroiglesias]

@adamtajti indeed it would be useful to raise awareness of that setting when the error occurs although given it really affects Git sync usage for some of us, it would be better (in my opinion) to have this released without any message on error than waiting much more for somebody to add the message to this PR.

[alejandroiglesias]

Any update on this?

[nakibmark]

@joaomoreno we need this merged

[joaomoreno]

All good, sorry for the delay everyone! Thanks! 🍻

[chriskinsman]

Was awaiting this to land in latest stable release and I find that when using git sync it doesn't appear to work. I have the setting checked to "Fetch all tags when pulling."

I think the issue is that the tag "latest" has changed remotely and so it differs from my local tag. The -f option is required to overwrite the local tag which this doesn't include. Seems like if you are turning this on you might want the -f flag by default. Should it be a different setting?

[nakibmark]

Uncheck that setting, that's the purpose of this PR. It'll run the sync without pulling down tags, and you can pull tags manually with -f in the CLI at some other point if you need to, when it's not disruptive to your development.

[chriskinsman]

Interesting. I want it always do a forced pull of tags which I guess is a little different...

…

On Mon, Jun 10, 2019 at 1:03 PM Mark Nakib ***@***.***> wrote: Uncheck that setting, that's the purpose of this PR. It'll run the sync without pulling down tags, and you can pull tags manually in the CLI at some other point if you need to, when it's not disruptive to your development. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#67527?email_source=notifications&email_token=AALTSYSZSLOCPX2N6INXMXDPZ2XSXA5CNFSM4GTG2WN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXLCDQY#issuecomment-500572611>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AALTSYTV4GG72X7Z7RVCNDLPZ2XSXANCNFSM4GTG2WNQ> .

[jextrevor]

Has this been released? I'm still having this issue in 1.39.2.

[jextrevor]

Never mind about that. I didn't see the setting at first, but when I unchecked "fetch all tags" sync now works.

[gusbemacbe]

"git.pullTags": false also worked.