Makefile colorizing tests - handling variable expansion in a variable name#67921
Merged
alexr00 merged 1 commit intomicrosoft:masterfrom Feb 6, 2019
fadeevab:makefile-update
Merged
Makefile colorizing tests - handling variable expansion in a variable name#67921alexr00 merged 1 commit intomicrosoft:masterfrom fadeevab:makefile-update
alexr00 merged 1 commit intomicrosoft:masterfrom
fadeevab:makefile-update
Conversation
… name in assignment: var-$(another-var) := value
Member
|
I pulled in the grammar changes again. Thank you for the test update! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the new grammar update, see below, the "$(another-var)" will be highlighted:
@alexr00 Just in a case if you pull makefile grammatic again, you would need an updated test case here (only additions, only green, grammar update is a backward compatible with old test cases).
Do it only after makefile grammatic update.