Ctrl+Click - Either open in Peek or go to definition, not BOTH!#68023
Merged
jrieken merged 1 commit intomicrosoft:masterfrom Feb 8, 2019
DerekZiemba:master
Merged
Ctrl+Click - Either open in Peek or go to definition, not BOTH!#68023jrieken merged 1 commit intomicrosoft:masterfrom DerekZiemba:master
jrieken merged 1 commit intomicrosoft:masterfrom
DerekZiemba:master
Conversation
* Use peek if there are multiple definitions * When using peek, will not navigate to the best match in editor and cause you to lose your spot * If there is only one definition, navigate to best match and NOT open peek
jrieken
added
feature-request
Member
|
thanks. |
|
This change brings inconsistent behaviors of the Go to Definition command, I don't think this PR should be merged, or at least you should give me an option to disable it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current behavior is if multiple definitions are found, it navigates to the nearest definition and opens peek. Which is super annoying and causes you to loose your place.
This addresses the following stack overflow complaint and behavior shown in the screencast
https://stackoverflow.com/questions/41460845/disable-peek-in-visual-studio-code/54559763#54559763