When wrapping with Emmet, consider the document language when setting the syntax.#68326
When wrapping with Emmet, consider the document language when setting the syntax.#68326octref merged 4 commits intomicrosoft:masterfrom
Conversation
|
@mattkwiecien Nice! Do you mind adding a test case for this in |
|
Absolutely! Will do either tonight or tomorrow morning. |
|
Added two unit tests for While I was in there, I noticed that a lot of the unit tests were re-writing existing logic in the |
|
@octref / @ramya-rao-a |
|
Just a small nitpick, looks good to me. Thanks! |
|
Awesome contribution, thank you! |
|
Thanks, really looking forward to contributing more to this great project :) |
doWrappingwas previously settingsyntax = 'htmlwhen wrapping with abbreviations. This was resulting in bad class attribute names forjsxfiles.argsparameter passed todoWrapping.argsparameter to be undefined, so added a guard clause to ensure that it iseditor.document.languageId.Now the
syntaxvalue is based on the return ofgetSyntaxFromArgs, and if the result of this function is undefined, default to'html'.This fixes #67098.