No csd linux by default#68640
Conversation
| return 'native'; // not enabled when developing due to https://github.com/electron/electron/issues/3647 | ||
| } | ||
|
|
||
| const accessibilityMode = configurationService.getValue('editor.accessibilitySupport'); |
| } | ||
|
|
||
| const accessibilityMode = configurationService.getValue('editor.accessibilitySupport'); | ||
| if (!isMacintosh && accessibilityMode) { |
There was a problem hiding this comment.
@sbatten the value of editor.accessibilitySupport is a string, so how does your check here actually work?
| run: () => { | ||
| this.storageService.store('menubar/electronFixRecommended', true, StorageScope.GLOBAL); | ||
| } | ||
| const message = nls.localize('menubar.linuxTitlebarRevertNotification', "We have updated the default title bar on Linux to use the native setting. If you prefer, you can go back to the custom setting "); |
There was a problem hiding this comment.
@sbatten why is there a trailing whitespace at the end of the sentence (you can go back to the custom setting )?
bpasero
left a comment
bpasero
left a comment
There was a problem hiding this comment.
@sbatten looks like you changed to show separate notifications now. LGTM with some polish:
- "Go to Setting" => "Open Settings"
- it looks like you always store the "Do not show again" state after showing the notification, shouldn't that be a decision that is made only by the user when clicking "Don't Show Again"?
|
@sbatten also, I would inline the "More Info" to be a link within the notification and not have it as extra button to reduce clutter. You can use markdown style styntax for that. |
|
@bpasero, updated to use inline link as suggested and switched back to Open Settings for consistency. I kept the behavior to not keep showing this message even without the user's input so as to not bug the user. The notifications are not critical unlike the previous notification to address an electron bug. |
|
@sbatten LGTM |
Revert the default custom title bar behavior on Linux
2 participants
No description provided.