Make EditStack correctly report canUndo#69239
Merged
alexdima merged 1 commit intomicrosoft:masterfrom Feb 27, 2019
trevorade:patch-1
Merged
Make EditStack correctly report canUndo#69239alexdima merged 1 commit intomicrosoft:masterfrom trevorade:patch-1
alexdima merged 1 commit intomicrosoft:masterfrom
trevorade:patch-1
Conversation
Currently, `canUndo()` will incorrectly return false in the case that `this.past.length` is `0` and `this.currentOpenStackElement` is populated. You can call `undo()` and it will do the right thing but there's no indication that you should be able to do it as `canUndo()` returns false.
Member
|
👍 Nice catch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
canUndo()will incorrectly return false in the case thatthis.past.lengthis0andthis.currentOpenStackElementis populated.You can call
undo()and it will do the right thing but there's no indication that you should be able to do it ascanUndo()returns false.