Skip to content

Allowing a user to change screencast mode overlay position and height/width from settings.#69314

Merged
joaomoreno merged 2 commits intomicrosoft:masterfrom
matt-april:master
Aug 7, 2019
Merged

Allowing a user to change screencast mode overlay position and height/width from settings.#69314
joaomoreno merged 2 commits intomicrosoft:masterfrom
matt-april:master

Conversation

@matt-april
Copy link

  • Added a new category to the workbench settings, Screencast Mode underneath Zen Mode. This gives us a place to put future screencast mode settings as more are requested.

  • Added 4 new settings to the Screencast Mode category, Vertical Position, Horizontal Position, Height, and Width, with default values that match the current hard coded values.

  • Updated developerActions.ts to pull the styles used for this overlay from the settings.

This fixes issue #66676.

@matt-april
Copy link
Author

@joaomoreno Any chance I could get a reviewer on this PR? Wanted to make sure this PR doesn't slip through the cracks!

@joaomoreno
Copy link
Member

@matt-april
Copy link
Author

@mattkwiecien Large backlog: https://github.com/Microsoft/vscode/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-desc+assignee%3Ajoaomoreno

oh my... haha, no worries just wanted to make sure this didn't split through the crack!

god speed.

@joaomoreno joaomoreno merged commit f54021d into microsoft:master Aug 7, 2019
@joaomoreno
Copy link
Member

I've just kept the vertical offset setting, I don't think we really need the other ones. Thanks! 🍻

@joaomoreno joaomoreno modified the milestones: Backlog, August 2019 Aug 7, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants