Allowing a user to change screencast mode overlay position and height/width from settings.#69314
Merged
joaomoreno merged 2 commits intomicrosoft:masterfrom Aug 7, 2019
Merged
Conversation
Author
|
@joaomoreno Any chance I could get a reviewer on this PR? Wanted to make sure this PR doesn't slip through the cracks! |
Member
|
@mattkwiecien Large backlog: https://github.com/Microsoft/vscode/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-desc+assignee%3Ajoaomoreno |
Author
oh my... haha, no worries just wanted to make sure this didn't split through the crack! god speed. |
Member
|
I've just kept the vertical offset setting, I don't think we really need the other ones. Thanks! 🍻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a new category to the workbench settings,
Screencast ModeunderneathZen Mode. This gives us a place to put future screencast mode settings as more are requested.Added 4 new settings to the
Screencast Modecategory,Vertical Position,Horizontal Position,Height, andWidth, with default values that match the current hard coded values.Updated
developerActions.tsto pull the styles used for this overlay from the settings.This fixes issue #66676.