Fixes #69583

[Kedstar99]

FIxes #69583

This patch removes the need to use lsof on linux platforms and instead uses the default readlink function in fs. It then reads directly the symbolic link in /proc. For all Linux based systems this should be fine.
http://man7.org/linux/man-pages/man5/proc.5.html

This approach should also be a lot faster compared to the previous lsof command. It also seems to work even if the user has remounted proc to hidepids.

ie mount -o remount,rw,hidepid=2 /proc

This solution will solve the case when users don't have lsof installed.

For OS X, I have kept the old lsof mechanism as they don't have a /proc directory.

EDIT:
Sorry, just refactored the code to make a little more sense. In this case, only run the commands if it is known to work on the respective platforms, otherwise fallback to just return _initialCwd.

[Tyriar]

@Kedstar99 wow great work! So much better than the approach I suggested 🙂

I made a change to handle err just to be safe (which I don't think should ever happen). I like the recent refactor too moving Windows to the bottom 👍

[Kedstar99]

Hi @Tyriar , thanks for merging.

I made a change to handle err just to be safe (which I don't think should ever happen).

Would it make sense to do the same if lsof doesn't work for Mac users? At least that way we can be certain it returns something.

I am happy to add another PR for that, but it seems rather unnecessary.

[Tyriar]

@Kedstar99 I'd say let's leave it as is unless someone complains on mac, seems like it's always built-in.