Add setting to make touchbar controls optional#70174
Add setting to make touchbar controls optional#70174bpasero merged 6 commits intomicrosoft:masterfrom MarcusNoble:optional_touchbar_controls
Conversation
|
|
src/vs/code/electron-main/window.ts
Outdated
| this.touchBarGroups.forEach((touchBarGroup, index) => { | ||
| const commands = groups[index]; | ||
| // Clear the segments first to prevent icon or label remaining | ||
| touchBarGroup.segments = []; |
There was a problem hiding this comment.
There seems to be a bug in electron where it doesn't correctly clear icons or labels when segments are replaced (See: electron/electron#17322). This gets around it by clearing out the segments then replacing them. No noticeable flicker when tested on my machine.
There was a problem hiding this comment.
This issue has been fixed in Electron (electron/electron#17336) but has yet to be released.
There was a problem hiding this comment.
This has now been released in https://github.com/electron/electron/releases/tag/v3.1.7
What is the process for updating dependencies of VSCode? Are there any guidelines that need to be followed?
|
Thanks, merged with the settings name |
3 participants
Related issues: #63865, #38333, on2-dev/nasc-vscode-mac-touchbar#9
Adds a new setting that allows the user to selectively have controls not appear in the touchbar without having to completely disable it.
Example settings to hide all debug controls but keep navigation:
{ "keyboard.touchbar.ignoreActions": [ "workbench.action.debug.start", "workbench.action.debug.run", "workbench.action.debug.restart", "workbench.action.debug.stepOver", "workbench.action.debug.stepInto", "workbench.action.debug.stepOut", "workbench.action.debug.stop", "workbench.action.debug.continue", "workbench.action.debug.pause" ] }This also allows people to use plugins that make use of the touchbar without having to also have the nav and debug controls (that take up much of the space).
Screenshots
Default:
Debug controls disabled:
Debug controls disabled with nasc-vscode-mac-touchbar extension enabled:
