Correctly handle succeeding ANSI color codes (fix #70416)#70502
Merged
isidorn merged 3 commits intomicrosoft:masterfrom Mar 15, 2019
iansan5653:master
Merged
Correctly handle succeeding ANSI color codes (fix #70416)#70502isidorn merged 3 commits intomicrosoft:masterfrom iansan5653:master
isidorn merged 3 commits intomicrosoft:masterfrom
iansan5653:master
Conversation
Avoids color conflicts by removing previous colors when new ones added. Fixes #70416.
Note: Modifies interference test behavior; prior test asserted undesired behavior.
Contributor
Author
|
I don't think it's my fault it's failing but I'm not familiar enough with Azure pipelines to say for certain. |
Collaborator
|
@iansan5653 thanks a lot for your PR. It looks good to me! Thanks for adding tests. Merging in. |
isidorn
added
the
debug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When parsing for ANSI color codes, succeeding codes will remove previous colors instead of adding new classes while ignoring existing ones. This will fix #70416.
Also added some unit tests and modified one existing one to account for the change.