Add new remote option when publishing branch#71434
Merged
joaomoreno merged 1 commit intomicrosoft:masterfrom Oct 17, 2019
Merged
Add new remote option when publishing branch#71434joaomoreno merged 1 commit intomicrosoft:masterfrom
joaomoreno merged 1 commit intomicrosoft:masterfrom
Conversation
Drockk
approved these changes
May 29, 2019
Drockk
approved these changes
May 29, 2019
mgyongyosi
reviewed
Jul 30, 2019
| if (choice === addRemote) { | ||
| const newRemote = await this.addRemote(repository); | ||
|
|
||
| if (newRemote) { |
There was a problem hiding this comment.
I think "if" statement can be inverted.
if (!newRemote) {
return;
}
remote = newRemote;
Member
|
Thanks! 🍻 I've added this to the |
|
Great. Now I have to pick |
Member
|
@rkeithhill I already reverted this in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the ability to add a new remote when publishing a branch. Closes #71242. Here is an example of creating a new branch, selecting the publish branch command, and creating a new remote. The branch gets published to that new remote.
I had a few questions about some ways to make the remote experience more consistent:
Should the ability to add a remote be an option on the "Push to.." and "Pull from..." menus as well?

Should the remotes on the "Publish branch" command show the remote URL, like the "Push to.." and "Pull from..." menus do?
