Skip to content

Fixes #68201 - adds qs.* label formatting tokens#71874

Merged
isidorn merged 1 commit intomicrosoft:masterfrom
eamodio:feature/#68201
Jul 30, 2019
Merged

Fixes #68201 - adds qs.* label formatting tokens#71874
isidorn merged 1 commit intomicrosoft:masterfrom
eamodio:feature/#68201

Conversation

@eamodio
Copy link
Contributor

@eamodio eamodio commented Apr 7, 2019

Addresses #68201

Allows ${qs.*} tokens in the resourceLabelFormatters.formatting.label, where the * is resolved to a property of the querystring json object (assuming it is a json object)

/cc @isidorn

@isidorn isidorn self-assigned this Apr 8, 2019
@isidorn
Copy link
Collaborator

isidorn commented Apr 8, 2019

Thanks for your PR.
However this milestone we are not focused on adding new features (more about that in the iteratino plan).
Thus putting this to on-deck for now.

@isidorn isidorn added this to the On Deck milestone Apr 8, 2019
@eamodio
Copy link
Contributor Author

eamodio commented Apr 8, 2019

Doh -- oh sir, it's only wafer thin 🤣

@eamodio
Copy link
Contributor Author

eamodio commented May 31, 2019

@isidorn Any chance for this soon?

@isidorn
Copy link
Collaborator

isidorn commented May 31, 2019

@eamodio you are the only user that wants this currently. I understand we could use this to better provide label in the explorer for the GitLens or RemoteHub extension but could you point me to a feature request for those extensions such that I possible get motivated to merge this in.

@eamodio
Copy link
Contributor Author

eamodio commented Jun 3, 2019

@isidorn I don't have any feature request that cover this (mainly because my uri hacks mostly provide a decent experience). It is more of debt that extensions have to pay in formatting uris in strange ways to get them to display nicely in the UI.

@isidorn
Copy link
Collaborator

isidorn commented Jun 4, 2019

Ok, that is good enough. This is nice work, so I would merge it in if we add some tests.
Here's a code pointer for tests https://github.com/Microsoft/vscode/blob/73643c60a644145c6a57b61787efd6a62e153cfa/src/vs/workbench/services/label/test/label.test.ts#L22

@eamodio
Copy link
Contributor Author

eamodio commented Jul 23, 2019

@isidorn sorry for the long delay on this. I've rebased it with master and added a handful of tests. Let me know what you think. 🤞 this can still make it for July.

@eamodio
Copy link
Contributor Author

eamodio commented Jul 30, 2019

@isidorn any chance? 😉

@isidorn
Copy link
Collaborator

isidorn commented Jul 30, 2019

@eamodio sorry for the slow response, I was on a 3 week vacation.
Thanks for adding tests. Great work! Merging in

@isidorn isidorn merged commit 1d7f8eb into microsoft:master Jul 30, 2019
@isidorn isidorn modified the milestones: On Deck, July 2019 Jul 30, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants