Skip to content

Use DOM scrollbar in SCM commit message box#72171

Merged
joaomoreno merged 1 commit intomicrosoft:masterfrom
jmbockhorst:scmScrollBar
Aug 8, 2019
Merged

Use DOM scrollbar in SCM commit message box#72171
joaomoreno merged 1 commit intomicrosoft:masterfrom
jmbockhorst:scmScrollBar

Conversation

@jmbockhorst
Copy link
Contributor

@jmbockhorst jmbockhorst commented Apr 11, 2019

Converted the SCM commit message box to use the native VS Code scrollbar instead of the default one. Closes #57158.
scroll

@joaomoreno joaomoreno changed the title Use native scrollbar in SCM commit message box Use DOM scrollbar in SCM commit message box Apr 12, 2019
@joaomoreno joaomoreno added the scm General SCM compound issues label Apr 12, 2019
@joaomoreno joaomoreno added this to the Backlog milestone Apr 12, 2019
@joaomoreno
Copy link
Member

joaomoreno commented Aug 8, 2019

Couple of problems with this:

  • Too much bleeds into SCM world. This should all be self contained in InputBox.
  • The ScrollableElement should be affecting the input element, not the div.
  • Holding down selection with the mouse doesn't auto reveal cursor any more.
  • Scrollbar wasn't updating on some events, e.g. paste.
  • Scrollbar wasn't fading out on mouse out, like other workbench scrollbars.

I've cleaned it all up. Thanks for your contribution! 🍻

@joaomoreno joaomoreno modified the milestones: Backlog, August 2019 Aug 8, 2019
@joaomoreno joaomoreno merged commit a9a0379 into microsoft:master Aug 8, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@joaomoreno joaomoreno

Labels

scm General SCM compound issues

Projects

None yet

Milestone

August 2019

Development

Successfully merging this pull request may close these issues.

Git commit message box in SCM view uses native scrollbar

2 participants

@jmbockhorst @joaomoreno