Fix-72650 Shell paths should be validated before launched to prevent ambiguous errors

[skprabhanjan]

@Tyriar , Added the changes to handle file path check to resolve #72650 .
For the async problem that you had raised , I have used fs.existsSync ( https://nodejs.org/api/fs.html#fs_fs_existssync_path)
Please review this and let me know if anything is not rite or needs to be changed , Thanks :)

[Tyriar]

Thanks for looking into this, got some comments below

[skprabhanjan]

@Tyriar , I have changed as per your comments , Please check and review the same :)

PS : I felt the try catch was no more required as the catch block was meant to catch only file not found exceptions.

[Tyriar]

I think just to be safe we should be checking if (this._ptyProcess) instead of using !, otherwise null pointer exceptions could slip in.

[skprabhanjan]

@Tyriar , Changes are done as per your reviews .
Added a new function setupPtyProcess which will be called in ctor if the file is found , Handled the error part first :)
Let me know if we do not need this new function and have to add the code there itself :)

PS: The build is still failing but not sure exactly why and is it because of these changes .

[Tyriar]

Wow my exitCodeMessage code really became a mess over time 😅, I cleaned that up a bit, also the path.basename was preventing the stat from working properly before.

[Tyriar]

Thanks @skprabhanjan, provided tests pass this time I'll merge this in for May soon 👍

[skprabhanjan]

@Tyriar, Thanks for the cleanup and few code changes related to path.basename :)
Yes if the tests pass then good to go , Thanks for reviewing it and getting this done from me :)