Skip to content

_validateShellPaths: skip file exists check for empty strings#72800

Merged
Tyriar merged 1 commit intomicrosoft:masterfrom
NizamLZ:fix/72601
May 10, 2019
Merged

_validateShellPaths: skip file exists check for empty strings#72800
Tyriar merged 1 commit intomicrosoft:masterfrom
NizamLZ:fix/72601

Conversation

@NizamLZ
Copy link
Contributor

@NizamLZ NizamLZ commented Apr 24, 2019

A minor change suggested by @roottool to resolve #72601

check for empty strings
@NizamLZ NizamLZ changed the title _validateShellPaths: skip for empty strings _validateShellPaths: skip file exists check for empty strings Apr 24, 2019
@Tyriar Tyriar added this to the May 2019 milestone Apr 26, 2019
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, will merge in soon for the May release 🙂

@Tyriar Tyriar merged commit 71920a1 into microsoft:master May 10, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The validation of shell paths does not work properly for empty strings

2 participants