Fix #72587 suggestWidget no scroll on first open#73625
Merged
joaomoreno merged 1 commit intomicrosoft:masterfrom Aug 8, 2019
Merged
Fix #72587 suggestWidget no scroll on first open#73625joaomoreno merged 1 commit intomicrosoft:masterfrom
joaomoreno merged 1 commit intomicrosoft:masterfrom
Conversation
If the first time the suggestWidget was opened (ctrl+space) its content vertically overflowed, it would not scroll. This commit fixes suggestWidget so that it scrolls tall content even on first use. The maxHeight must be set before scanDomNode checks clientHeight.
Contributor
Author
|
@joaomoreno Is there anything else I should do on this PR? |
Member
|
Thanks! 🍻 cc @jrieken |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the first time the suggestWidget was opened (ctrl+space) its
content vertically overflowed, it would not scroll. This commit fixes
suggestWidget so that it scrolls tall content even on first use.
The maxHeight must be set before scanDomNode checks clientHeight.