Merged
Conversation
Collaborator
|
How did you test this? |
Contributor
Author
|
First, I built vscode on Windows 10 and tested on it. Then, I tested the issue on the other two OSs by the virtual machine. |
Collaborator
|
What input methods did you use to verify this? Mainly scroll wheel, track pad. It seems to work ok on macos. The scroll wheel zoom behavior now matches what photoshop does |
Contributor
Author
|
I tested three kinds of zoom in/out ways.
|
Collaborator
|
Ok, let's merge this to insiders and see if it causes any problems for real world users |
Collaborator
|
The fix will be in the next VS Code insiders build |
This was referenced May 17, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.