Fix-73465 Toggle search view position should also appear in empty search view#73808
Merged
roblourens merged 2 commits intomicrosoft:masterfrom May 17, 2019
Merged
Fix-73465 Toggle search view position should also appear in empty search view#73808roblourens merged 2 commits intomicrosoft:masterfrom
roblourens merged 2 commits intomicrosoft:masterfrom
Conversation
…e and No Search Results
roblourens
reviewed
May 17, 2019
Member
There was a problem hiding this comment.
This looks great, just
- move the reLayout outside of
if (completed). I can break the layout now if I start a search then immediately cancel it to get the "canceled before any results found" message - delete commented out lines
- Make sure your git email address is correct so your commits are attributed to your gh account
Contributor
Author
|
@roblourens , All changes done :) |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

@roblourens , Tweaked Toggle Search Position Feature to work on empty tree and No Search Results as per our discussion to fix #73465 . ( I have just commented the lines and not removed them , just one addition of calling
reLayout()again)Please review it and let me know if there are any changes. I have attached a video showing all use cases.
https://drive.google.com/file/d/1EJCRRuven-pmXS20Pr1e3-4aocrM5i-c/view?usp=sharing