Skip to content

Fix-73465 Toggle search view position should also appear in empty search view#73808

Merged
roblourens merged 2 commits intomicrosoft:masterfrom
skprabhanjan:fix-73465
May 17, 2019
Merged

Fix-73465 Toggle search view position should also appear in empty search view#73808
roblourens merged 2 commits intomicrosoft:masterfrom
skprabhanjan:fix-73465

Conversation

@skprabhanjan
Copy link
Contributor

@roblourens , Tweaked Toggle Search Position Feature to work on empty tree and No Search Results as per our discussion to fix #73465 . ( I have just commented the lines and not removed them , just one addition of calling reLayout() again)
Please review it and let me know if there are any changes. I have attached a video showing all use cases.

https://drive.google.com/file/d/1EJCRRuven-pmXS20Pr1e3-4aocrM5i-c/view?usp=sharing

@roblourens roblourens self-assigned this May 16, 2019
Copy link
Member

@roblourens roblourens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, just

  • move the reLayout outside of if (completed). I can break the layout now if I start a search then immediately cancel it to get the "canceled before any results found" message
  • delete commented out lines
  • Make sure your git email address is correct so your commits are attributed to your gh account

@skprabhanjan
Copy link
Contributor Author

skprabhanjan commented May 17, 2019

@roblourens , All changes done :)
And also I have corrected my email address , could you also help me understand how you figured that out and what happens to the previous PR's that I have made ?
Sorry for the trouble , my commits shows this but I have 10 merged PR's ( here )

@roblourens
Copy link
Member

No problem, I just noticed that your commit was not attributed to a GH user, you can see the difference here:
image

Not sure how some commits ended up correct previously, it might be that the PR was rebased or squashed in which case GH would have rewritten the commit using your GH user email address.

@roblourens roblourens merged commit a2be028 into microsoft:master May 17, 2019
@roblourens roblourens added this to the May 2019 milestone May 31, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Toggle search view position should also appear in empty search view

3 participants