Allow multi-line comment auto-closing for C++ files#73841
Merged
alexr00 merged 2 commits intomicrosoft:masterfrom May 21, 2019
Merged
Allow multi-line comment auto-closing for C++ files#73841alexr00 merged 2 commits intomicrosoft:masterfrom
alexr00 merged 2 commits intomicrosoft:masterfrom
Conversation
Adds support for auto-closing a multi-line comment pair when typing in a C++ language file. This is for quicker comment creation and is already done for every other character pairings. However, was never added for multi-line comments until now.
alexr00
requested changes
May 16, 2019
| { "open": "'", "close": "'", "notIn": ["string", "comment"] }, | ||
| { "open": "\"", "close": "\"", "notIn": ["string"] } | ||
| { "open": "\"", "close": "\"", "notIn": ["string"] }, | ||
| { "open": "/*", "close": " */", "notIn": ["string"] } |
Member
There was a problem hiding this comment.
Works great, but can you add "comment" to the notIn too?
Contributor
Author
There was a problem hiding this comment.
Definitely! Thanks for the feedback, I will do this now.
In feedback it was suggested to make sure that multiline comments don't autocomplete in comments in addition to strings.
AdrianDeAnda
approved these changes
May 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #72801.
Summary:
It has been suggested to add support for auto-closing a multi-line comment pair (
/* */) when typing in a C++ language file. It is now possible to simply type/*in a .cpp file and it will auto-complete to/* */.