Preserve whitespace in debug hover expresion value#73954
Merged
isidorn merged 1 commit intomicrosoft:masterfrom May 24, 2019
Merged
Preserve whitespace in debug hover expresion value#73954isidorn merged 1 commit intomicrosoft:masterfrom
isidorn merged 1 commit intomicrosoft:masterfrom
Conversation
Collaborator
|
This is a great PR, thanks a lot for it! |
jeanp413
commented
May 23, 2019
| } | ||
|
|
||
| .monaco-workbench .debug-viewlet .monaco-list-row .expression { | ||
| white-space: pre; |
Contributor
Author
There was a problem hiding this comment.
@isidorn the variables view already preserved whitespaces here, I just deleted this to avoid redundant css rules and moved it to debug.contribution.css. If I change it to nowrap it would be the same issue as it would be an incorrect/misleading value for strings containing whitespaces.
Collaborator
|
Looks good, thanks a lot. Let's merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #73241