add quick open/input color registers#74041
Merged
chrmarti merged 1 commit intomicrosoft:masterfrom Jun 24, 2019
chaseadamsio-forks:freeQuickPickerColors
Merged
add quick open/input color registers#74041chrmarti merged 1 commit intomicrosoft:masterfrom chaseadamsio-forks:freeQuickPickerColors
chrmarti merged 1 commit intomicrosoft:masterfrom
chaseadamsio-forks:freeQuickPickerColors
Conversation
Contributor
|
The changes make sense to me, but assigning to @chrmarti as he's the owner of the (various) quick pick UIs |
Contributor
Author
|
Hey @alexr00, any chance you've been able to mull this over? If you have any questions / suggestions I'm open to them! |
Collaborator
|
Thanks @chaseadamsio ! |
|
it's not working. |
Contributor
Author
|
Looks like there was a commit here: cc6b5c3 where For reference, for anyone who finds this in the future, the following: has been replaced with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to extract the color registration for the quick opener/quick input so that it can be styled separately from the Sidebar.
Currently, it's pulling whatever styles are create on the sidebar for foreground and background. This isn't intuitive for theme developers (personally, I struggled to remember which register to use and I only figured it out because of others having the same experience and discussing on Stack Overflow). It's also limiting in that it forces theme developers into making a decision about both the sidebar and the quick picker.
I want to propose registering two new color selectors:
"quickOpen.background""quickOpen.foreground"Here's an example after running
./scripts/code.shonmasterand the PR branch.Before (

master):After (

freeQuickPickerColors, in my theme I set the background color to a darker black fo the"quickOpen.background"and left"sideBar.background"the same):