Conversation
|
|
extensions/git/src/commands.ts
Outdated
|
|
||
| @command('git.deleteTag', { repository: true }) | ||
| async deleteTag(repository: Repository): Promise<void> { | ||
| const inputTagName = await window.showInputBox({ |
There was a problem hiding this comment.
We shouldn't be asking the user to provide a tag name here. We should show the user a picker to choose which tag should be deleted.
There was a problem hiding this comment.
Good point, I will try to implement the suggested solution in the coming week. Thank you for the feedback.
|
|
||
| class TagItem implements QuickPickItem { | ||
|
|
||
| get label(): string { return (this.tag.name || '').substr(0, 20); } |
There was a problem hiding this comment.
Hi @joaomoreno , I would like your input on the label length allowed for the quick pick items. For now, I am arbitrarily cropping the tag label to 20 characters , this rest of the line is taken by the tag message. I am wondering if 20 characters is ok?
|
Hi @joaomoreno , I made the requested changes by adding a quick pick Item. Let me know if there is anything I could do to make this better. |
|
I've cleaned it up and made it simpler. Great job @xuhas, thanks a lot! 🍻 |
4 participants
Hi, this is my first try at contributing and I tried to tackle the feature request for deleting tags in a given git repo (#74147) .
My changes are based on the createTag command.
Let me know if there is something I could change to make this better.