Handle multiple users with /tmp/vscode-typescript

[asztal]

This fixes an issue where the typescript language server fails to load if multiple users launch VS Code on the same Linux machine.

Steps to reproduce:

• Log in as user1
• Launch VS Code
• Log out
• Log in as user2
• Launch VS Code
• It tries to write to files in /tmp/vscode-typescript, but that directory is not writeable because it is owned by user1
• You cannot use TypeScript intellisense

This fix namespaces the directory with the current uid so that each user will get their own.

On Windows, this shouldn't be an issue anyway since each user gets their own temp directory.

[mjbvz]

Thanks for the PR. Just two quick things:

• Can you please create an issue for this is. Include the steps to reproduce the problem. This helps us track and test what is delivered each milestone.

• Can we exclude windows from the new logic? We've seen a few users complain about a large number of vscode directories under temp, which apparently isn't automatically cleaned up like on most unix systems. Having a single folder avoids polluting the top level of temp directory on windows even if we don't properly clean up

[asztal]

Sure, I'll create an issue when I can. I'm not sure if it's as simple as I thought, or I probably would have come across this sooner.

process.getuid doesn't exist on windows, as far as I know, so it should work as before - I'll check and add a comment to that effect.

[mjbvz]

Sounds good. If you can, please just try to create the issue over this weekend so we can merge this PR in before we lock down for the 1.36 release

[asztal]

I haven't been able to verify that process.getuid really is undefined on Windows, I don't have it installed unfortunately - but the node source code does confirm it.
https://github.com/nodejs/node/blob/master/lib/internal/bootstrap/node.js#L120

In any case, I assume on Windows each user has their own temp directory so windows users would have already been getting separate vscode-typescript caches per user?

[mjbvz]

Thanks for creating the issue.

Yes, I think that's that case on windows. I just don't want to create separate directories per process for windows specifically. Can you please make just make this explicit by adding a check such as process.platform !== 'win32'

[mjbvz]

Thanks. Will add the explicit platform check