Makes status zoom button a IStatusbarEntry #74454#75618
Merged
mjbvz merged 1 commit intomicrosoft:masterfrom Jun 21, 2019
Merged
Makes status zoom button a IStatusbarEntry #74454#75618mjbvz merged 1 commit intomicrosoft:masterfrom
mjbvz merged 1 commit intomicrosoft:masterfrom
Conversation
|
|
Member
|
@burknator can you also remove the |
ZoomStatusbarItem can now be instantiated, which is done in InlineImageView, which it uses to update the status bar. The needed services are passed down via constructors, starting in BaseBinaryResourceEditor. Removes padding from CSS which was necessary because of previous implementation.
burknator
force-pushed
the
fixes/image-zoom-button
branch
from
9691997 to
a4ac3aa
Compare
Contributor
Author
|
Of course! Took mental note of that, should've written it down instead... |
Collaborator
|
Thanks! Scheduled for VS Code 1.36 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #74454
ZoomStatusbarItem can now be instantiated, which is done in
InlineImageView, which it uses to update the status bar.
The needed services are passed down via constructors,
starting in BaseBinaryResourceEditor.
Also, the ID of status bar items is now assigned as the
id-attribute of the item's container.