Conversation
Closed
mjbvz
reviewed
Jun 27, 2019
src/vs/workbench/contrib/webview/electron-browser/webviewElement.ts
Outdated
Show resolved
Hide resolved
deepak1556
commented
Jul 3, 2019
bpasero
requested changes
Jul 6, 2019
src/vs/code/electron-main/windows.ts
Outdated
| dialog.showMessageBox(options, callback); | ||
| dialogPromise = dialog.showMessageBox(options); | ||
| } | ||
| dialogPromise.then(({ response, checkboxChecked }: Electron.MessageBoxReturnValue) => { |
Contributor
|
Sorry for off topic, but I wanted to say thanks to @deepak1556 for this PR, I tried it and finally font weight is fixed with this Electron version. I'm very happy and looking forward to using Insiders with Electron 6.x. 🎆 |
Member
|
@deepak1556 fyi see afcd155 for converting dialogs to |
4 tasks
Collaborator
Author
|
The macOS crash is due to new helper binaries introduced with electron/electron#19324 , will need to update Edit: joaomoreno/gulp-atom-electron#55 /cc @joaomoreno |
|
Electron 6.0.0-beta.15 is out the previous one, .14 updated to Node 12.4.0 Noticed some webview issues fixed which could help?
|
bpasero
reviewed
Aug 5, 2019
This was referenced Aug 13, 2019
Closed
This was referenced Aug 20, 2019
|
Version update available: electron/electron@10a9e9c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Electron: 6.0.7
Nodejs version: 12.4.0
V8 version: 7.6.303.29
Chromium version: 76.0.3809.139