Skip to content

Suppress MsgBox when Wizard is running in silent mode#76215

Merged
joaomoreno merged 3 commits intomicrosoft:masterfrom
piraces:setup-msgbox-not-suppressed
Jun 27, 2019
Merged

Suppress MsgBox when Wizard is running in silent mode#76215
joaomoreno merged 3 commits intomicrosoft:masterfrom
piraces:setup-msgbox-not-suppressed

Conversation

@piraces
Copy link
Contributor

@piraces piraces commented Jun 26, 2019

Fixes #75281

I have been able to reproduce the issue with both system and user installers of last stable version (1.35.1).

I have been testing building the setup binary with the fix and the bug is fixed. Following the steps in the issue with this fixes results with exit code 1 with no message boxes or dialogs (as expected, because other installation for other arch is installed).

@joaomoreno joaomoreno merged commit 90d25d0 into microsoft:master Jun 27, 2019
@joaomoreno joaomoreno added this to the June 2019 milestone Jun 27, 2019
@joaomoreno
Copy link
Member

Awesome, thanks! 🍻

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setup dialog not suppressed with /SUPPRESSMSGBOXES /VERYSILENT

2 participants