Fix middle mouse button opening broken release notes link in browser#76487
Merged
mjbvz merged 2 commits intomicrosoft:masterfrom Aug 15, 2019
Merged
Fix middle mouse button opening broken release notes link in browser#76487mjbvz merged 2 commits intomicrosoft:masterfrom
mjbvz merged 2 commits intomicrosoft:masterfrom
Conversation
diguifi
reviewed
Jul 4, 2019
|
|
||
| // Bubble out link clicks | ||
| newFrame.contentWindow.addEventListener('click', handleInnerClick); | ||
| newFrame.contentWindow.addEventListener('mousedown', handleInnerClick); |
Contributor
Author
There was a problem hiding this comment.
Because the click event only fires on left mouse button clicks. To prevent the middle mouse button from opening broken links in the browser, I needed to have an event that fires on middle clicks as well.
diguifi
approved these changes
Jul 5, 2019
Collaborator
|
Thanks! This will be in the next VS Code insiders build. We will see if it causes any problem for people using various input setups |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #76042
The middle mouse button now has the same effect as the left and right mouse button.
Clicking a link with the middle mouse button scrolls down to the clicked section instead of opening a broken link in the browser.
I tested this by temporarily changing the product version to 1.35 in package.json. Otherwise I was not able to open the release notes. I changed it back to 1.37 for this commit.