Skip to content

Support Update VS Code from Command Palette#77515

Merged
joaomoreno merged 2 commits intomicrosoft:masterfrom
webclipper:feat/checkUpdate
Oct 25, 2019
Merged

Support Update VS Code from Command Palette#77515
joaomoreno merged 2 commits intomicrosoft:masterfrom
webclipper:feat/checkUpdate

Conversation

@DiamondYuan
Copy link
Contributor

@DiamondYuan DiamondYuan commented Jul 17, 2019

close #77184

@msftclas
Copy link

msftclas commented Jul 17, 2019 •
edited
Loading

CLA assistant check
All CLA requirements met.

@DiamondYuan
Copy link
Contributor Author

DiamondYuan commented Jul 18, 2019

@joaomoreno

CI broken,How to fix it ?

src/vs/workbench/contrib/update/common/update.ts:6:48:Unexternalized string found: "update.showCurrentReleaseNotes"
src/vs/workbench/contrib/update/common/update.ts:7:45:Unexternalized string found: "update.checkForVSCodeUpdate"

joaomoreno
joaomoreno requested changes Jul 18, 2019
View reviewed changes
Copy link
Member

@joaomoreno joaomoreno left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge both classes, there's no need for an abstract class here.

joaomoreno
joaomoreno requested changes Jul 18, 2019
View reviewed changes
@DiamondYuan
Copy link
Contributor Author

DiamondYuan commented Jul 18, 2019

Please merge both classes, there's no need for an abstract class here.

Ci Broken,Time out

@joaomoreno
Copy link
Member

joaomoreno commented Jul 18, 2019 •
edited
Loading

CI is not broken. You are using double quotes instead of double quotes. CI is telling you exactly that.

@DiamondYuan
Copy link
Contributor Author

DiamondYuan commented Jul 18, 2019 •
edited
Loading

CI is not broken. You are using double quotes instead of double quotes. CI is telling you exactly that.

image

https://dev.azure.com/vscode/VSCode/_build/results?buildId=23300

Last CI broken was due to timeout. I have solved the error.

@joaomoreno joaomoreno added this to the Backlog milestone Jul 18, 2019
@joaomoreno joaomoreno added the install-update VS Code installation and upgrade system issues label Jul 18, 2019
@DiamondYuan
Copy link
Contributor Author

DiamondYuan commented Jul 23, 2019

cc @joaomoreno when will whit PR be merged ?

@georgiai1 georgiai1 mentioned this pull request Sep 5, 2019
Closed
@joaomoreno joaomoreno merged commit 264ec27 into microsoft:master Oct 25, 2019
@joaomoreno
Copy link
Member

joaomoreno commented Oct 25, 2019

Thanks! 🍻

@joaomoreno joaomoreno modified the milestones: Backlog, October 2019 Oct 25, 2019
@joaomoreno joaomoreno mentioned this pull request Oct 25, 2019
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@joaomoreno joaomoreno joaomoreno requested changes

+1 more reviewer

@ian-sawyer ian-sawyer ian-sawyer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@joaomoreno joaomoreno

Labels

install-update VS Code installation and upgrade system issues

Projects

None yet

Milestone

October 2019

Development

Successfully merging this pull request may close these issues.

Update VS Code from Command Palette

4 participants

@DiamondYuan @msftclas @joaomoreno @ian-sawyer