#56286 Add a configuration option to show/hide icons in the breadcrumbs view#78879
Merged
jrieken merged 2 commits intomicrosoft:masterfrom Aug 13, 2019
Merged
#56286 Add a configuration option to show/hide icons in the breadcrumbs view#78879jrieken merged 2 commits intomicrosoft:masterfrom
jrieken merged 2 commits intomicrosoft:masterfrom
Conversation
|
|
jrieken
reviewed
Aug 12, 2019
Member
There was a problem hiding this comment.
also check for showing symbol icons?
Member
|
This looks pretty good. I believe the equally checks need to be extended to also compare the symbol icons - that should be testable when using no tabs - |
Author
|
Added the symbol icon to the equality check - confirmed that when breadcrumb.icons and editor.showTabs are disabled, symbol icons aren't shown. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #56286.
Adds a config option, breadcrumbs.icons, which controls whether or not icons are shown in the breadcrumbs view