Allow goToLine to work backwards#79348
Merged
bpasero merged 2 commits intomicrosoft:masterfrom Aug 26, 2019
Merged
Conversation
diguifi
approved these changes
Aug 21, 2019
MJ-Mohith
approved these changes
Aug 22, 2019
bpasero
requested changes
Aug 25, 2019
Member
bpasero
left a comment
bpasero
left a comment
There was a problem hiding this comment.
This needs to still check for the line being valid though:
jmannanc
force-pushed
the
gotoline-negative
branch
from
866ce41 to
33e53ee
Compare
Contributor
Author
|
Good catch! Just pushed a fix for it. |
Member
|
Thanks 👍 |
Contributor
Author
|
Thanks for merging, just wanted to reiterate my original question about the docs. Would there be anything I need to change or no? |
Member
|
Thanks for asking, I actually think we do not even document this feature on https://code.visualstudio.com/docs, but if you can find it we can update it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #79286
Are there any docs that would need editing too with a change like this?