Fix explorer item creation and disposal#79383
Conversation
There was a problem hiding this comment.
This fixes the bug from the second gif from #78153 (comment)
There was a problem hiding this comment.
Can you please put this in a seperate PR. I like this simple change and it is in the tree land so I would love if we merge it in unrelated to this.
There was a problem hiding this comment.
Can you please put this in a seperate PR. I like this simple change and it is in the tree land so I would love if we merge it in unrelated to this.
There was a problem hiding this comment.
Why not use getEditableData?
That API is already there and gives you everything you need.
There was a problem hiding this comment.
getEditableData just return the data, I need the stat so I can call this.tree.getRelativeTop(editable.stat)
|
@jeanp413 thanks a lot for your PR. Also did you intensivly test this out? There are quite some corner cases (as you are probably aware of). And this code is quite delicate (hacky). |
a7e7cd1 to
8e86e73
Compare
|
@jeanp413 thanks for the PR and for updating it. |
|
I have tested this now more. Seems to work fine and looks good. Let's merge it in to get feedback from insiders users. |
This PR reapplies the changes from #72627 and the improvements from here and here.
Adittionaly has some changes to fix #78153 reported issues