Fix-79525 New pattern to Preserve Case ( hyphen separated variables)#79528
Merged
rebornix merged 4 commits intomicrosoft:masterfrom Aug 22, 2019
Merged
Fix-79525 New pattern to Preserve Case ( hyphen separated variables)#79528rebornix merged 4 commits intomicrosoft:masterfrom
rebornix merged 4 commits intomicrosoft:masterfrom
Conversation
roblourens
approved these changes
Aug 22, 2019
Contributor
Author
|
@roblourens , Sorry is there something still pending or missing for this to get merged ? |
Member
|
It looks ok to me, but I want @rebornix to look at it too. |
Contributor
Author
|
Cool , Thanks a lot for the review :) |
rebornix
reviewed
Aug 22, 2019
rebornix
requested changes
Aug 22, 2019
Member
rebornix
left a comment
rebornix
left a comment
There was a problem hiding this comment.
Looks good to me in overral, just a tiny suggestion.
Contributor
Author
|
@rebornix , Fast return is done now :) |
Member
|
@skprabhanjan thanks for your contribution! |
djoffe
reviewed
Aug 23, 2019
djoffe
left a comment
djoffe
left a comment
There was a problem hiding this comment.
Sorry for the nitpicking... Was just reading that piece of code and thought I would let you know!
Contributor
Author
Thanks for this , Fixed it here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@roblourens , Added this logic for hyphen casing example I mentioned in #79525.
I have handled all the edge cases I would think of , Please review this and let me know.
PS : I think underscore will also be an option ( Just like what I have done here for hyphens ) but it has to be either all hyphens or all underscore and not a mix( For example
foo-bar_item) and I know no one use names variables like that but handling it in code is complicated. ( Maybe if you say yes to underscore then I can open a new issue and then implement that.FYI : @rebornix .