Fix-79658 New pattern to Preserve Case ( underscore separated variables)#79660
Merged
roblourens merged 2 commits intomicrosoft:masterfrom Sep 11, 2019
Merged
Fix-79658 New pattern to Preserve Case ( underscore separated variables)#79660roblourens merged 2 commits intomicrosoft:masterfrom
roblourens merged 2 commits intomicrosoft:masterfrom
Conversation
Contributor
Author
|
@roblourens and @rebornix |
roblourens
approved these changes
Sep 5, 2019
Member
roblourens
left a comment
roblourens
left a comment
There was a problem hiding this comment.
LGTM, will let @rebornix review too
Contributor
Author
|
@rebornix , Any updates on this ? |
Member
|
He's on paternity leave now but I think it's fine, I'll merge it. |
Contributor
Author
|
@roblourens , sorry I did not know he was on leave and thanks for merging it 😁 |
|
See my comment here: #79525 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@roblourens and @rebornix , Here is the implementation to handle underscore characters as well to fix #79658 ( As mentioned implemented it as two disjoint sets of replacement )
Please review this and let me know , Thanks :)
PS : if you feel the request itself is not a valid one then feel free to close it :) ( I thought underscore was also useful in some places )