Skip to content

Use const instead of let#79770

Merged
RMacfarlane merged 2 commits intomicrosoft:masterfrom
mbelsky:prefer-const
Aug 27, 2019
Merged

Use const instead of let#79770
RMacfarlane merged 2 commits intomicrosoft:masterfrom
mbelsky:prefer-const

Conversation

@mbelsky
Copy link
Contributor

@mbelsky mbelsky commented Aug 25, 2019

Hey,
With eslint's prefer-const rule I've found a few variables that declared as let but them never rewritten. Does this project have any guidelines to take let or const?

@msftclas
Copy link

msftclas commented Aug 25, 2019

CLA assistant check
All CLA requirements met.

@RMacfarlane RMacfarlane self-assigned this Aug 26, 2019
@itsmunim
Copy link

@RMacfarlane won't it be better to do a rebase with master instead of merging master into it and having a merge commit for that? Not a great history to look at!

git pull --rebase upstream master

@RMacfarlane
Copy link
Contributor

@dibosh I typically use squash when merging something back into master, so it should ultimately be fine. That merge commit was from hitting the "Update branch" button that GitHub now exposes.

@RMacfarlane RMacfarlane merged commit d3605cc into microsoft:master Aug 27, 2019
@RMacfarlane RMacfarlane added this to the August 2019 milestone Aug 27, 2019
@RMacfarlane
Copy link
Contributor

@mbelsky This project doesn't have guidelines for let vs const, but I think this change is good so I've merged it in. Thanks!

@mbelsky mbelsky deleted the prefer-const branch August 27, 2019 20:15
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants