Use const instead of let#79770
Merged
RMacfarlane merged 2 commits intomicrosoft:masterfrom Aug 27, 2019
mbelsky:prefer-const
Merged
Use const instead of let#79770RMacfarlane merged 2 commits intomicrosoft:masterfrom mbelsky:prefer-const
RMacfarlane merged 2 commits intomicrosoft:masterfrom
mbelsky:prefer-const
Conversation
|
@RMacfarlane won't it be better to do a rebase with
|
Contributor
|
@dibosh I typically use squash when merging something back into master, so it should ultimately be fine. That merge commit was from hitting the "Update branch" button that GitHub now exposes. |
Contributor
|
@mbelsky This project doesn't have guidelines for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
With eslint's
prefer-construle I've found a few variables that declared asletbut them never rewritten. Does this project have any guidelines to take let or const?