Config option to separate or hide untracked files (addresses #35480)#80083
Merged
joaomoreno merged 2 commits intomicrosoft:masterfrom Oct 25, 2019
Merged
Config option to separate or hide untracked files (addresses #35480)#80083joaomoreno merged 2 commits intomicrosoft:masterfrom
joaomoreno merged 2 commits intomicrosoft:masterfrom
Conversation
joaomoreno
reviewed
Oct 25, 2019
Member
joaomoreno
left a comment
There was a problem hiding this comment.
Just some general comments. I like the overall approach. I'm going to give it a good test drive and a final review and will try to merge it today.
| "displayName": "Git", | ||
| "description": "Git SCM Integration", | ||
| "displayName": "Hide Untracked Files (Git)", | ||
| "description": "Copy of the built-in Git extension which hides untracked files", |
Member
There was a problem hiding this comment.
These seem leftover changes.
| .getConfiguration('git', Uri.file(repository.root)) | ||
| .get<'withchanges' | 'separate' | 'hide'>('handleUntracked') || | ||
| 'withchanges'; | ||
| let includeUntracked; |
Member
|
Did a lot of cleanup:
|
Member
|
Great job overall, definitely the bulk of the work! Thanks! 🍻 |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an option to the Git extension,
handleUntracked, which changes how it handles untracked files. The options are:withchanges: Untracked files are displayed with other changed files. My intention is that should not affect VSCode's current behaviorseparate: Untracked files are in a separateUNTRACKEDsection below theCHANGESsection. When staging all changes, a dialog will ask the user if they want to include untracked files or not.hide: Untracked files are completely hidden from the changes list. They are also not counted in the badge (even ifallis selected)I figure this might need more work, or maybe it's not the best approach. But currently it makes it much easier to use VSCode's git capabilities for projects with a lot of untracked files.
Fixes #35480