Improve template literals support to match TS#80234
Merged
mjbvz merged 1 commit intomicrosoft:masterfrom Nov 4, 2019
Merged
Conversation
7 tasks
IllusionMH
force-pushed
the
better-tempate-literal-support
branch
from
eb42f0f to
a458b7d
Compare
Contributor
Author
|
Ooops, forgot about this one. 🤦♂ PR microsoft/TypeScript#32064 is merged and after investigation across other services there is nothing that needs updates on VS Code side. It was planned for VS Code version shipped with 3.7 |
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR microsoft/TypeScript#32064 brings several improvements to how template literals are treated.
Currently I'm working on improving handling of template literals in various TS services and will update this PR if any changes needed to support updated functionality.
Current list of changes:
`in the same way as when they type'or"(as per suggestion in Better template literals support in checker TypeScript#32064 (comment))