Replace Disposable[] with DisposableStore#80447
Merged
mjbvz merged 4 commits intomicrosoft:masterfrom Sep 9, 2019
solomatov:first-pr-vscode
Merged
Replace Disposable[] with DisposableStore#80447mjbvz merged 4 commits intomicrosoft:masterfrom solomatov:first-pr-vscode
mjbvz merged 4 commits intomicrosoft:masterfrom
solomatov:first-pr-vscode
Conversation
Contributor
Author
|
If it's ok, I can do more of it. There aren't that many usages of Disposable[] as a DisposableStore. |
mjbvz
reviewed
Sep 9, 2019
Contributor
Author
|
And what do you think about more of such contributions? I want to learn the codebase, and such changes are a good way to learn about it. |
mjbvz
reviewed
Sep 9, 2019
| } | ||
|
|
||
| this.cache = new RowCache(this.renderers); | ||
| this.cache = this.disposables.add(new RowCache(this.renderers)); |
Collaborator
There was a problem hiding this comment.
Make sure to call this.disposables.clear() before adding the new entries. This resets the store (which is what the re-assignment previously was simulating)
Collaborator
There was a problem hiding this comment.
Actually never mind. I see this is in the constructor so it's not required
Collaborator
|
Thanks. We would take other PRs like this. Please just keep each PR small and isolated so they are easy to review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #74250 for details.