Fix activation of linters on unopened files caused by markdown plugin#80506
Merged
mjbvz merged 11 commits intomicrosoft:masterfrom Sep 11, 2019
solomatov:md-opendoc-bug
Merged
Fix activation of linters on unopened files caused by markdown plugin#80506mjbvz merged 11 commits intomicrosoft:masterfrom solomatov:md-opendoc-bug
mjbvz merged 11 commits intomicrosoft:masterfrom
solomatov:md-opendoc-bug
Conversation
…markdown extension opening TextDocuments during indexing
OmarTawfik
reviewed
Sep 7, 2019
extensions/markdown-language-features/src/commands/openDocumentLink.ts
Outdated
Show resolved
Hide resolved
extensions/markdown-language-features/src/features/workspaceSymbolProvider.ts
Outdated
Show resolved
Hide resolved
extensions/markdown-language-features/src/features/workspaceSymbolProvider.ts
Outdated
Show resolved
Hide resolved
extensions/markdown-language-features/src/features/workspaceSymbolProvider.ts
Outdated
Show resolved
Hide resolved
extensions/markdown-language-features/src/tableOfContentsProvider.ts
Outdated
Show resolved
Hide resolved
extensions/markdown-language-features/src/tableOfContentsProvider.ts
Outdated
Show resolved
Hide resolved
extensions/markdown-language-features/src/tableOfContentsProvider.ts
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@mjbvz Do you have any other things to fix in the review? |
mjbvz
requested changes
Sep 11, 2019
Collaborator
mjbvz
left a comment
There was a problem hiding this comment.
This is going in the correct direction but want to make sure we don't make the more common uses of TableOfContentsProvider more inefficient. Let me know if you have any questions about the comments
extensions/markdown-language-features/src/features/workspaceSymbolProvider.ts
Outdated
Show resolved
Hide resolved
extensions/markdown-language-features/src/tableOfContentsProvider.ts
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@mjbvz It seems that I fixed all your suggestions. Thanks for them, they made the code better and much shorter. |
Collaborator
|
Thanks for the PR and for the changes! Looks good to me. This will be in the next VS Code insiders build and is scheduled to ship with VS Code 1.39 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's the issue: #50874
Solution: