snap: add assets verbatim#80585
Merged
joaomoreno merged 8 commits intomicrosoft:masterfrom Sep 10, 2019
Merged
Conversation
Providing the desktop files in snap/gui will have snapcraft copy over
those assets into the snaps meta/gui verbatim.
Addtionally, add a leading ${SNAP} to the Icon entry which was also
moved to snap/gui for the "package" to have an icon by default
(which is important when sideloading).
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
|
|
Member
|
@sergiusens Thanks for pushing us in the right direction. I had to push a few more commits on top, but everything looks like it works properly! |
This was referenced Sep 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Providing the desktop files in snap/gui will have snapcraft copy over
those assets into the snaps meta/gui verbatim.
Addtionally, add a leading ${SNAP} to the Icon entry which was also
moved to snap/gui for the "package" to have an icon by default
(which is important when sideloading).
Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com