[typescript-language-features] Add formatter option for semicolons#80828
Merged
mjbvz merged 3 commits intomicrosoft:masterfrom Sep 13, 2019
Merged
[typescript-language-features] Add formatter option for semicolons#80828mjbvz merged 3 commits intomicrosoft:masterfrom
mjbvz merged 3 commits intomicrosoft:masterfrom
Conversation
mjbvz
requested changes
Sep 13, 2019
Collaborator
mjbvz
left a comment
mjbvz
left a comment
There was a problem hiding this comment.
LGTM. To get testing, I'd like to merge this before we actually start shipping 3.7 so let's avoid using the new types
| insertSpaceAfterTypeAssertion: config.get<boolean>('insertSpaceAfterTypeAssertion'), | ||
| placeOpenBraceOnNewLineForFunctions: config.get<boolean>('placeOpenBraceOnNewLineForFunctions'), | ||
| placeOpenBraceOnNewLineForControlBlocks: config.get<boolean>('placeOpenBraceOnNewLineForControlBlocks'), | ||
| semicolons: config.get<Proto.SemicolonPreference>('semicolons'), |
Collaborator
There was a problem hiding this comment.
So that we can merge this before VS Code includes TS 3.7, just use a normal string for now (or inline the string literal types)
Member
Author
There was a problem hiding this comment.
Done. I had to modify the type of the object to get away with adding the additional property. Left a note that it can be removed after 3.7 is adopted.
Member
Author
|
Flaky Windows build? |
Collaborator
|
Yep, failure seems unrelated. Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Counterpart to microsoft/TypeScript#33402
Build will fail because I’m referencing the updated protocol from the TS PR—not sure how you handle proto updates but this will have to wait at least until the TS PR is merged.