Merged
Conversation
Contributor
Author
|
@jrieken can you review my PR please? thanks! |
Collaborator
|
Thanks for looking into this issue. However this file is at a very low level in VS Code (and from the external Instead, I think we should scope the fix to just the TypeScript extension. Here's the file where I believe this logic lives: |
13eda83 to
9507d77
Compare
Contributor
Author
|
@mjbvz can you please re-review? Thanks! |
Collaborator
|
Thanks! Fix will be in the next insiders build and is scheduled to go out with VS Code 1.42 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addresses #80790
I believe this is the best method of rendering the hover JSDoc author tag email address correctly, but open to any suggestions.
Also, I am unsure whether this issue also pertains to
vscode/src/vs/base/common/marked/marked.js
Lines 820 to 841 in 7aff0c4
mailto