A readOnly editor doesn't honor readonly in the textArea#81394
Merged
alexdima merged 3 commits intomicrosoft:masterfrom Sep 30, 2019
Merged
A readOnly editor doesn't honor readonly in the textArea#81394alexdima merged 3 commits intomicrosoft:masterfrom
alexdima merged 3 commits intomicrosoft:masterfrom
Conversation
… controls on mobile devices. The underlying cause is the TextArea element is missing the readonly attribute. This change applies the readonly attribute when the editor is created or the configuration changes to editor.readOnly === true.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing an issue where a readOnly editor will still activate the input controls on mobile devices.
The underlying cause is the TextArea element is missing the readonly attribute.
This change applies the readonly attribute when the editor is created or the configuration changes to editor.readOnly === true.