Fix to allow for optional chain token in completions#81402
Merged
mjbvz merged 1 commit intomicrosoft:masterfrom Sep 25, 2019
Merged
Fix to allow for optional chain token in completions#81402mjbvz merged 1 commit intomicrosoft:masterfrom
mjbvz merged 1 commit intomicrosoft:masterfrom
Conversation
Author
|
cc: @mjbvz |
Collaborator
|
Thanks! |
This was referenced Sep 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where completions for non-identifier member names are ignored because the TypeScriptCompletionItemProvider was only looking for the preceding
.token and did not include the optional chain token?.. This resulted in an incorrect filter text when applied to the list of available completions:With this change, the completion list is filtered properly: