Add support for touch events on the suggest widget (Fixes #78984)#81442
Merged
octref merged 5 commits intomicrosoft:masterfrom Sep 26, 2019
Merged
Add support for touch events on the suggest widget (Fixes #78984)#81442octref merged 5 commits intomicrosoft:masterfrom
octref merged 5 commits intomicrosoft:masterfrom
Conversation
octref
suggested changes
Sep 26, 2019
Contributor
octref
left a comment
octref
left a comment
There was a problem hiding this comment.
Changes LGTM and works great 👍
Let's not duplicate code and name the function onListMouseDownOrTap.
…ap in SuggestWidget
Contributor
Author
|
Thanks for the feedback, refactored as suggested, using a union type of |
octref
approved these changes
Sep 26, 2019
Contributor
|
🚢 it. Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #78984
Works by implementing a
onListTapevent listener for a tapGestureEventon theSuggestWidgetclass. The new listener runs the same code as theonListMouseDownevent listener.If you think it's best to extract the
onListTap()andonListMouseDown()functions in order to avoid duplicated code please let me know, I didn't do it right away since it's just a couple lines of code.