search: remove unused config settings#82019
Merged
roblourens merged 1 commit intomicrosoft:masterfrom Oct 16, 2019
Merged
Conversation
`searchRipgrep.enable` and `search.runInExtensionHost` are no longer used. A code search for `searchRipgrep` and `runInExtensionHost` shows no matches. While they were originally used to determine if searches should be run with ripgrep, they were later replaced with `search.useRipgrep`. That setting itself is now deprecated and does the same thing as `search.usePCRE2` (so it actually doesn't disable ripgrep), but at least it does something. So delete these settings that are beyond deprecation - they do nothing.
|
|
Member
|
Thanks. I think |
Member
|
Yeah I might bring it back later but don't have any reason to do that now so I'll merge this, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
searchRipgrep.enableandsearch.runInExtensionHostare no longerused. A code search for
searchRipgrepandrunInExtensionHostshowsno matches.
While they were originally used to determine if searches should be run
with ripgrep, they were later replaced with
search.useRipgrep. Thatsetting itself is now deprecated and does the same thing as
search.usePCRE2(so it actually doesn't disable ripgrep), but at leastit does something.
So delete these settings that are beyond deprecation - they do nothing.
cc @roblourens