Skip to content

Render Octicons in CodeLens#82062

Merged
jrieken merged 1 commit intomicrosoft:masterfrom
kondratyev-nv:master
Oct 8, 2019
Merged

Render Octicons in CodeLens#82062
jrieken merged 1 commit intomicrosoft:masterfrom
kondratyev-nv:master

Conversation

@kondratyev-nv
Copy link
Contributor

@kondratyev-nv kondratyev-nv commented Oct 7, 2019

Fixes #19582. renderOcticons includes previously used escape function and also resolves Octicons.

@jrieken jrieken self-assigned this Oct 8, 2019
@jrieken jrieken added this to the October 2019 milestone Oct 8, 2019
jrieken
jrieken approved these changes Oct 8, 2019
View reviewed changes
Copy link
Member

@jrieken jrieken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jrieken jrieken merged commit 178b598 into microsoft:master Oct 8, 2019
@AidanGG AidanGG mentioned this pull request Oct 20, 2019
Closed
@jdneo
Copy link
Member

jdneo commented Nov 18, 2019

I found that when a Code Lens which only contains the Octicon, like $(check). The binding command could not be triggered anymore. Is that a regression? See: #85007

@jrieken jrieken mentioned this pull request Nov 18, 2019
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jrieken jrieken jrieken approved these changes

Assignees

@jrieken jrieken

Labels

None yet

Projects

None yet

Milestone

October 2019

Development

Successfully merging this pull request may close these issues.

Add ability to display icons in Code Lenses

3 participants

@kondratyev-nv @jdneo @jrieken