linux/bin/code.sh: use command -v instead of which#82097
Merged
Tyriar merged 1 commit intomicrosoft:masterfrom Oct 8, 2019
jplatte:patch-1
Merged
linux/bin/code.sh: use command -v instead of which#82097Tyriar merged 1 commit intomicrosoft:masterfrom jplatte:patch-1
Tyriar merged 1 commit intomicrosoft:masterfrom
jplatte:patch-1
Conversation
|
More generally, see https://unix.stackexchange.com/questions/85249/why-not-use-which-what-to-use-then
Thanks for doing your part to help get us one step closer to a world in which the "which" program is not used. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
commandis a bash-builtin (see the Bash manual) that is guaranteed to always be present, in contrast towhich, which is not required to be available for bash to work.This dependency on
whichhas recently caused an issue for a small percentage of arch linux users where VSCode wouldn't start anymore, see visual-studio-code-bin on the AUR. By removing the dependency, VSCode becomes a tiny bit more self-contained (unless it's still used somewhere else of course).