fix: remove TypeScript from ExtensionSuggestions#82125
Merged
mjbvz merged 2 commits intomicrosoft:masterfrom Oct 8, 2019
jsjoeio:jsjoeio/remove-ts-welcome
Merged
fix: remove TypeScript from ExtensionSuggestions#82125mjbvz merged 2 commits intomicrosoft:masterfrom jsjoeio:jsjoeio/remove-ts-welcome
mjbvz merged 2 commits intomicrosoft:masterfrom
jsjoeio:jsjoeio/remove-ts-welcome
Conversation
mjbvz
reviewed
Oct 8, 2019
| const extensionPacks: ExtensionSuggestion[] = [ | ||
| { name: localize('welcomePage.javaScript', "JavaScript"), id: 'dbaeumer.vscode-eslint' }, | ||
| { name: localize('welcomePage.typeScript', "TypeScript"), id: 'ms-vscode.vscode-typescript-tslint-plugin' }, | ||
| // { name: localize('welcomePage.typeScript', "TypeScript"), id: 'ms-vscode.vscode-typescript-tslint-plugin' }, |
Collaborator
There was a problem hiding this comment.
Can you please just delete this line instead. No reason to keep it around
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #82053
Changes
Screenshot
Additional Context
Originally, the Welcome page suggested users working with TypeScript install the TSLint extension. However, the TSLint extension is being deprecated in favor of ESLint. Instead of recommending ESLint, @mjbvz suggested dropping the TypeScript section altogether for now.