Open New Terminal -> Open New External Terminal#82380
Merged
Tyriar merged 2 commits intomicrosoft:masterfrom Oct 14, 2019
solomatov:change-new-terminal-title
Merged
Open New Terminal -> Open New External Terminal#82380Tyriar merged 2 commits intomicrosoft:masterfrom solomatov:change-new-terminal-title
Tyriar merged 2 commits intomicrosoft:masterfrom
solomatov:change-new-terminal-title
Conversation
Tyriar
requested changes
Oct 11, 2019
Member
Tyriar
left a comment
Tyriar
left a comment
There was a problem hiding this comment.
👎 to adding cmd+shift+ since ctrl+shift+ is a companion to ctrl+, and cmd+ can't be added as it's an OS-level keybinding.
src/vs/workbench/contrib/externalTerminal/browser/externalTerminal.contribution.ts
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open New Terminal command palette action is confusing since people expect it to open internal terminal, but it opens external terminal instead. I changed the title to make it less confusing.
Also, what do you think about assigning it to Cmd+Shift+` on the Mac so that we have some kind of uniformity in shortcuts?